(chore) Bump framework and update patient banner props #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +362 kB (+5.9%) 🔍 Total Size: 6.49 MB
ℹ️ View Unchanged
|
denniskigen
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Thanks for working on this, @vasharma05. I've taken the liberty of pushing a commit that, among other small tweaks:
- Also updates the version of the Common Lib dependency (in the hopes of fixing this issue)
- Switching from using
String(Math.random())to generate random UUIDs for thenameandaddressproperties of the FHIR patient object to usinguuidv4which actually generates unique v4 UUIDs.
denniskigen
reviewed
Oct 11, 2024
Comment on lines
+1
to
+4
| import React, { forwardRef, useContext, useMemo } from 'react'; | ||
| import classNames from 'classnames'; | ||
| import { v4 as uuidv4 } from 'uuid'; | ||
| import { useTranslation } from 'react-i18next'; |
There was a problem hiding this comment.
This change just reorganises the imports (note to self to prioritise work on adding https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/order.md to our ESLint config for automatically handling this concern)
Comment on lines
-135
to
-138
| interface ClickablePatientContainerProps { | ||
| patientUuid: string; | ||
| children: React.ReactNode; | ||
| } |
There was a problem hiding this comment.
I've just lifted this interface higher up in the file.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR bumps the framework and openmrs tooling, and updates the patient banner props following the changes in openmrs/openmrs-esm-core#1158
Screenshots
None
Related Issue
None
Other