(fix) O3-4004 - ward app - better way to fix patient action menu button in workspace #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kb019, please follow PR conventions strictly, including the title. |
kb019
changed the title
Hi @vasharma05 , since this was a redo, i was not sure what to put as title (I mean (fix) or (undo) ) . I have updated both title and PR description. Thanks . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Because patient is already passed as a prop to patient-workspace , i think we dont need to explicitly pass the ward-patient prop when calling launchWorkspace in
WardPatientActionButton. So undoing the changes which i have done here.I think this is the correct way and that was done temporarily to unblock the issue. Thanks.OpenMRS.-.Personal.-.Microsoft_.Edge.2024-10-14.20-54-07.webm
PR
https://openmrs.atlassian.net/browse/O3-4004
cc: @chibongho