-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-4118: Service queues patient list should not be in a 'widget' / 'tile' #1390
base: main
Are you sure you want to change the base?
Conversation
cb19f1e
to
e7c1a3f
Compare
@jwnasambu , it looks like you've tagged a bunch of random strangers. Sorry, random strangers. There is quite a bit more to the ticket than what you've implemented here. Do you intend to finish implementing the feature as designed? |
Thanks @brandones! You are right I tagged random strangers. I should have tagged them on the Jira issues because I don’t know their Github accounts. Also, I’d like to continue with the implementation, but I am stuck on what to do next because there were some questions regarding what needs to be fixed. I was hoping to get clarification from these members." Apparently I am fixing the merge conflicts. |
Currently the active visit list (Patients currently in queue in the screenshot below) is placed on a tile This is incorrect. It should be simply on the page, with a grey background as you can see in the mock-up below This mock-up is available on Zeplin here: https://zpl.io/aN3L75n |
e7c1a3f
to
0db9b5f
Compare
0db9b5f
to
0d17ab7
Compare
0b138c9
to
8a08a4b
Compare
d0a4e5b
to
978dfdb
Compare
@brandones, @ciaranduffy Kindly, this is my finding, and I stand to be corrected. There are two classes with different background colors i.e. one is white and the other gray, which I believe is showing an unnecessary Layer or something and a border around the table, making it look like it’s a card instead of just part of the page. After changing the background colors the issue appears to be fixed. Kindly feel free to correct me, please! and point out what I am missing in my implementation. |
Requirements
Summary
I renamed 'Patients currently in queue' to 'Active visits' for better clarity on the Service queues patient list.
Screenshots
Before making changes
After making changes
Related Issue
https://openmrs.atlassian.net/browse/O3-4118
Other