Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix):O3-4209 Enhance stock operation validations to support negative stock adjustments #240

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

makombe
Copy link
Contributor

@makombe makombe commented Nov 19, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The quantity field in stock operations is currently validated to prevent the entry of negative numbers. However, for negative stock adjustments, entering negative quantities should be permitted to reflect accurate adjustments. This validation should be updated to allow negative values specifically for negative stock adjustment operations.

Screenshots

Screencast.from.19-11-2024.10.52.13.ASUBUHI.webm

Related Issue

https://openmrs.atlassian.net/browse/O3-4209

Other

Copy link

@ojwanganto ojwanganto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @makombe

@ojwanganto
Copy link

@makombe - please create a ticket for this and update in the PR description

Copy link
Collaborator

@jabahum jabahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @makombe

@jabahum jabahum merged commit 91e084c into openmrs:main Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants