Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U4X-264 : Add bulk items import #37

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

jabahum
Copy link
Collaborator

@jabahum jabahum commented Dec 11, 2023

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

https://metsprogramme.atlassian.net/browse/U4X-264

Other

@jabahum jabahum force-pushed the ft/bulk-stock-item-import branch from 3572712 to 9866008 Compare December 12, 2023 09:10
@makombe
Copy link
Contributor

makombe commented Dec 13, 2023

@slubwama, @akileng56 Are you at a position to help review this, Our QA would like to test the import feature with a template sample we have already populated. Thanks

@jabahum jabahum self-assigned this Dec 13, 2023
@jabahum jabahum added the enhancement New feature or request label Dec 14, 2023
@jabahum jabahum linked an issue Dec 14, 2023 that may be closed by this pull request
11 tasks
@jabahum
Copy link
Collaborator Author

jabahum commented Dec 14, 2023

@slubwama, @akileng56 Are you at a position to help review this, Our QA would like to test the import feature with a template sample we have already populated. Thanks

@makombe there is an issue on the backend side holding this PR @slubwama is working on this

@jabahum jabahum changed the title Ft/bulk-stock-item-import U4X-264 : Add bulk items import Dec 14, 2023
@jabahum jabahum removed a link to an issue Dec 14, 2023
11 tasks
@jabahum jabahum force-pushed the ft/bulk-stock-item-import branch from 274e195 to 9d901c4 Compare January 10, 2024 07:52
@ojwanganto
Copy link

@slubwama @jabahum any updates on this?

@jabahum
Copy link
Collaborator Author

jabahum commented Jan 10, 2024

@Mwanje is looking into this PR to test

@ojwanganto
Copy link

Thanks for the feedback

@Mwanje
Copy link
Collaborator

Mwanje commented Jan 15, 2024

@slubwama the current import file structure needs to be reorganised to accommodate numeric fields.

@makombe
Copy link
Contributor

makombe commented Jan 15, 2024

@jabahum, @Mwanje @slubwama what do you think, can we merge this in then we can move it forward from there? The fixes can be done in follow up PR

@makombe makombe merged commit 24d3f60 into openmrs:main Jan 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants