Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U4X-289 : Deleting stock sources #47

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

jabahum
Copy link
Collaborator

@jabahum jabahum commented Dec 14, 2023

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Screen.Recording.2023-12-14.at.12.49.28.mov

Related Issue

https://metsprogramme.atlassian.net/browse/U4X-289

Other

@jabahum jabahum self-assigned this Dec 14, 2023
@jabahum jabahum requested review from slubwama and Mwanje December 14, 2023 09:35
@jabahum jabahum added the enhancement New feature or request label Dec 14, 2023
@slubwama slubwama changed the title feat(stock) : U4X-289 Deleting stocksources U4X-289: Deleting stocksources Dec 14, 2023
@jabahum jabahum changed the title U4X-289: Deleting stocksources U4X-289c: Deleting stock sources Dec 14, 2023
@slubwama slubwama changed the title U4X-289c: Deleting stock sources U4X-289: Deleting stock sources Dec 14, 2023
@jabahum jabahum changed the title U4X-289: Deleting stock sources U4X-289 : Deleting stock sources Dec 14, 2023
@jabahum jabahum linked an issue Dec 14, 2023 that may be closed by this pull request
11 tasks
@jabahum jabahum removed a link to an issue Dec 14, 2023
11 tasks
kind="ghost"
size="md"
onClick={() => handleClick()}
iconDescription={t("editStockItem", "Edit Stock Item")}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
iconDescription={t("editStockItem", "Edit Stock Item")}
iconDescription={t("editStockSource", "Edit Stock Source")}

(error) => {
setDeletingSource(false);
showNotification({
title: t(`errorDeletingSource', 'error deleting a source`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: t(`errorDeletingSource', 'error deleting a source`),
title: t(`errorDeletingSource', 'Error deleting a stock source`),

@Mwanje Mwanje merged commit e79635f into openmrs:main Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants