Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) O3-2514 : Setup the template repository with playwright #18

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

RandilaP
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

The goal of this PR is to set up the esm template repository for E2E testing with playwright

Screenshots

Related Issue

https://issues.openmrs.org/browse/O3-2514

Other

@RandilaP
Copy link
Contributor Author

@jayasanka-sack Could you please review this

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RandilaP. I've added some comments. Let me know what you think.

e2e/specs/initiate-test.spec.ts Outdated Show resolved Hide resolved
e2e/specs/initiate-test.spec.ts Outdated Show resolved Hide resolved
e2e/README.md Outdated Show resolved Hide resolved
e2e/README.md Outdated Show resolved Hide resolved
@jayasanka-sack
Copy link
Member

jayasanka-sack commented Nov 23, 2023

Also, update the jest config file to skip playwright test files (that's why the build is failing).
check this file: https://github.com/jayasanka-sack/openmrs-esm-patient-management/blob/main/jest.config.js

testPathIgnorePatterns: [path.resolve(__dirname, 'e2e')],
collectCoverageFrom....

@RandilaP
Copy link
Contributor Author

@jayasanka-sack Could you please review this

@jayasanka-sack
Copy link
Member

@RandilaP the build is still failing. could you please check?

@RandilaP
Copy link
Contributor Author

@jayasanka-sack Could you please approve the workflow

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RandilaP !

@jayasanka-sack jayasanka-sack merged commit 987c415 into openmrs:main Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants