Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Update tooling #34

Merged
merged 1 commit into from
Aug 8, 2024
Merged

(chore) Update tooling #34

merged 1 commit into from
Aug 8, 2024

Conversation

NethmiRodrigo
Copy link
Contributor

@NethmiRodrigo NethmiRodrigo commented Jul 19, 2024

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

This PR updates the core and tooling.

Screenshots

Related Issue

Other

@NethmiRodrigo
Copy link
Contributor Author

@denniskigen does the build failing with the tooling update have anything to do with the webpack config? Should we do any changes there? Or do you have any insight as to why the build is failing?

@ibacher
Copy link
Member

ibacher commented Aug 8, 2024

Yeah, this was my bad. I think if we update again it will work.

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denniskigen denniskigen merged commit 0398e51 into main Aug 8, 2024
5 checks passed
@NethmiRodrigo NethmiRodrigo deleted the chore/update-tooling branch August 29, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants