(test) O3-3610 : Unit test for rendering tutorials #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piumal1999
reviewed
Jul 16, 2024
Comment on lines
77
to
81
| if (element) { | ||
| console.log('Found element:', element); | ||
| } else { | ||
| console.log('Element not found for:', step.content); | ||
| } |
There was a problem hiding this comment.
No need to use console logs here. You can use an assertion.
jayasanka-sack
requested changes
Aug 1, 2024
Comment on lines
71
to
74
| const walkthroughButton = screen.getByText('Basic Tutorial').closest('.tutorialItem').querySelector('.walkthrough'); | ||
| await user.click(walkthroughButton); | ||
|
|
||
| await waitFor(() => { |
There was a problem hiding this comment.
What this test should do is it should check if it lists down all the tutorials. No need to click them nor to go through the steps.
Should be something like:
for all tutorial in tutorials:
expect the tutorial title and description is loaded properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Added test for rendering tutorials.
Screenshots
Related Issue
Other
O3-3610