Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATT-53: Add privileges for attachments #65

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

Seremba
Copy link
Contributor

@Seremba Seremba commented May 7, 2024

Defined "Create Attachment" and "View Attachment" privileges in this module so users don't have to add them manually to the system

@elimm
Copy link

elimm commented May 9, 2024

@Seremba Thanks for the great work!
@ibacher Pls take a look

@ibacher ibacher changed the title ATT-53: Attachments privileges ATT-53: Add privileges for attachments May 9, 2024
@ibacher
Copy link
Member

ibacher commented May 9, 2024

Nice work @Seremba. Could you also add the appropriate annotations to the methods in the service? (I.e., save should get "Create Attachments", the methods which return attachments should require "View Attachments"). Also, since this is a major overhaul, let's update the version to 4.0.0-SNAPSHOT.

@Seremba
Copy link
Contributor Author

Seremba commented May 11, 2024

Thanks @ibacher, I have made changes as you suggested. Kindly take a look. Thanks a lot! cc @elimm

@ibacher ibacher merged commit 8e2823e into openmrs:master Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants