Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC 2019: Patient Search Criteria Module #216

Closed
wants to merge 1 commit into from

Conversation

Reyano132
Copy link

@Reyano132 Reyano132 commented Jul 23, 2019

https://wiki.openmrs.org/display/projects/Patient+Search+Criteria

New patient search criteria added in the ''find Patient" widget.

@Reyano132 Reyano132 force-pushed the gsoc branch 2 times, most recently from 0d7145b to cd88214 Compare July 23, 2019 15:32
@HerbertYiga
Copy link
Contributor

@Reyano132 am testing out this module

@Reyano132
Copy link
Author

If you face any difficulty at time of building of the module, just change the version of the node from 6.10.0 to 6.17.0

@Reyano132 Reyano132 force-pushed the gsoc branch 2 times, most recently from d55e5a2 to 49d404e Compare July 28, 2019 10:37
@dkayiwa
Copy link
Member

dkayiwa commented Aug 6, 2019

@Reyano132 are you aware of these merge conflicts?

@Reyano132
Copy link
Author

sir, I'm working on this PR. At the end of this week, PR will be ready for merge

@Reyano132 Reyano132 force-pushed the gsoc branch 15 times, most recently from cb5c762 to c5a71e0 Compare August 18, 2019 11:19
@mozzy11
Copy link
Member

mozzy11 commented Aug 19, 2019

@Reyano132 have you seen the merge conflicts ??

@mozzy11
Copy link
Member

mozzy11 commented Aug 20, 2019

@Reyano132 can you squash your commits into one as advised here https://wiki.openmrs.org/display/docs/Pull+Request+Tips

@Reyano132
Copy link
Author

@mozzy11 , I squashed the commits, still, the problem with Travic CI remains. Also, due to squash, all the other files which I did not change become part of the PR.

@mozzy11
Copy link
Member

mozzy11 commented Aug 21, 2019

hi @Reyano132 , now to clean up this,
, can you clone a fresh copy of the core apps, and first make sure you pull the latest changes from upstream. Then You'll make a new PR , with this solution https://stackoverflow.com/questions/55674746/travis-sh-0-cant-open-etc-init-d-xvfb

@Reyano132
Copy link
Author

Here is my new PR : #219

@Reyano132 Reyano132 closed this Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants