-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC 2019: Patient search criteria module #219
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,15 @@ | |
<gem.path>${basedir}/.rubygems</gem.path> | ||
</properties> | ||
|
||
<!-- Repository for patient search criteria --> | ||
<repositories> | ||
<repository> | ||
<id>jitpack.io</id> | ||
<url>https://jitpack.io</url> | ||
</repository> | ||
</repositories> | ||
|
||
|
||
<dependencies> | ||
|
||
<!-- | ||
|
@@ -255,6 +264,25 @@ | |
<scope>provided</scope> | ||
</dependency> | ||
|
||
<!-- Patient search criteria module --> | ||
<dependency> | ||
<groupId>com.github.Reyano132.openmrs-module-patientsearchcriteria</groupId> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please revise this groupid to match our conventions https://wiki.openmrs.org/display/docs/Module+Conventions There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kaweesi sir, here I used jitpack to host my remote repository. Jitpack added "com.github.Reyano132" prefix to the group ID. Once we officially host the patient search criteria module (https://github.com/openmrs/openmrs-module-patientsearchcriteria), I'll change the groupId value here. |
||
<artifactId>patientsearch-api</artifactId> | ||
<version>v1.0.0</version> | ||
<scope>provided</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>com.github.Reyano132.openmrs-module-patientsearchcriteria</groupId> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
<artifactId>patientsearch-omod</artifactId> | ||
<version>v1.0.0</version> | ||
<scope>provided</scope> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.springframework</groupId> | ||
<artifactId>spring-core</artifactId> | ||
<version>4.0.5.RELEASE</version> | ||
</dependency> | ||
|
||
</dependencies> | ||
|
||
<build> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea why u wanna publish these on jitpack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaweesi sir, I added this repository in PR so you can use the patient search criteria module(which is not merge yet). Once you merge patient search criteria module PR(openmrs/openmrs-module-patientsearchcriteria#1) and create its remote repository, I will replace this jitpack with that repository. Another thing is that the PR of patient search criteria also consists of a jitpack repository of openmrs-core(openmrs/openmrs-core#2980).
Overall, there are dependencies between the PRs as I explained in the talk.
please 1st merge openmrs core PR(openmrs/openmrs-core#2980).
Then merge patient search criteria module PR(openmrs/openmrs-module-patientsearchcriteria#1) and create a remote repository of that module and at last, after creating a repository of patient search criteria module I just need to replace jitpack repository with patient search criteria repository