FM2-492: Create a real integration test for the Observation domain #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
=========================================
Coverage 79.97% 79.97%
Complexity 2422 2422
=========================================
Files 224 224
Lines 6565 6565
Branches 777 777
=========================================
Hits 5250 5250
Misses 842 842
Partials 473 473 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jnsereko
commented
Aug 10, 2022
|
|
||
| public class ObservationDomainTest { | ||
|
|
||
| private static final String SERVER_BASE = "http://localhost:8080/openmrs/ws/fhir2/R4"; |
There was a problem hiding this comment.
i think this has to be added to the FhirConstants.java or i should create my own class in under this module and add all constants there
jnsereko
commented
Aug 10, 2022
|
|
||
| private static String observationUuid = "34d45fr6-f3a9-4f46-8341-15f0de3d8476"; | ||
|
|
||
| private static final String OBSERVATION_PATIENT_UUID = "58c57d25-8d39-41ab-8422-108a0c277d98"; |
There was a problem hiding this comment.
Does out docker instance come with any sample data. If not, i think it will save us alot of time referencing existing patients than creating new ones each time we need a patient
|
|
||
| private static final String OBSERVATION_ENCOUNTER_UUID_1 = "58c57d25-8d39-41ab-8422-108a0c277d98"; | ||
|
|
||
| private static final String OBSERVATION_ENCOUNTER_UUID_2 = "58c57d25-8d39-41ab-8422-108a0c277d98"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
/openmrs/ws/fhir2/R4/Observation/<uuid>returns a valid FHIR observation./openmrs/ws/fhir2/R4/Observationwith a request body consisting of a JSON observation should create observation./openmrs/ws/fhir2/R4/Observation/<uuid>with a request body consisting of a JSON observation should update the details of the observation record./openmrs/ws/fhir2/R4/Observation/<uuid>should void the observationIssue I worked on
see https://issues.openmrs.org/browse/FM2-492
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master