FM2-613: Upgrade Hapi Fhir version to v5.7.9 #521
Conversation
There was a problem hiding this comment.
There is need to create a custom class that inherits the VersionConvertorFactory_30_40 class since in this version of Hapi Fhir, accessing convertion class is no longer possible.
Quoted from here!-> Note that these classes are not intended to be used directly. When actually converting resources, the provided conversion factory classes are intended to be used as the entry point. For example, to convert a dstu3 AllergyIntolerance resource, the above conversion would not use AllergyIntolerance40_50 directly, but would instead call: VersionConvertorFactory_40_50.convertResource(dstu3AllergyIntolerance). VersionConvertorFactory_40_50 would call AllergyIntolerance40_50 internally to convert r4AllergyIntolerance.
cc: @ibacher
which explains the failing test on Tasks |
|
@mherman22 Sorry, I missed this PR until now. Yep, that looks to be a problem. I'm going to try a couple of things to see if we can avoid doing that, since it sounds like a lot of code. |
|
Well, we've got a new error now, I guess. Not sure if HAPI moved where the Pointcut definitions are stored? |
Will look into it tonight |
|
These very tests were failing in intellij and when i ran So, the PointCut class didnt really change that much in the version( FYI: i was following the conversation at hapifhir/hapi-fhir#316 (comment), especially that comment. cc: @ibacher |
|
@mherman22 Are you running |
I guess I should run that and report back. |
|
So, it looks like this problem arises because of the version of Jackson we're using. I don't see any easy way forward that will continue to support older versions of OpenMRS. In any case, we were going to dump support for pre-2.4.x versions at some point, so I guess that's now a prerequisite for this. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
============================================
+ Coverage 77.79% 77.82% +0.03%
+ Complexity 2679 2678 -1
============================================
Files 239 239
Lines 7430 7440 +10
Branches 897 897
============================================
+ Hits 5780 5790 +10
Misses 1114 1114
Partials 536 536
☔ View full report in Codecov by Sentry. |
|
@mherman22 Would you be able to take care of getting this PR to work with the new 2.0.0-SNAPSHOT version? |
Alright, lemi do that |
|
@ibacher you can take a look. |
|
Nice work @mherman22! |
Description of what I changed
https://github.com/hapifhir/org.hl7.fhir.core/tree/master/org.hl7.fhir.convertors
Issue I worked on
see https://issues.openmrs.org/browse/FM2-613
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master