Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FM2-636: Enhancements in Existing FHIR Task Resource #539

Merged
merged 5 commits into from
May 20, 2024

Conversation

kalai-tw
Copy link
Contributor

Description of what I changed

Made below Changes to FHIR Task Entity Model:

  • Added new columns to fhir_task:

    • task_code: to determine task type
    • execution_start_time: start time of execution
    • execution_end_time: end time of execution
    • comment: comment to task
  • Added a new table fhir_part_of_reference to support subtasks to a parent task.

Issue I worked on

see https://issues.openmrs.org/browse/FM2-636
talk thread ref https://talk.openmrs.org/t/contribution-to-fhir-task/42015

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

  • I have added tests to cover my changes.

  • I ran mvn clean package right before creating this pull request

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

FM2-636: Enhancements in Existing FHIR Task Resource (#5)
@kalai-tw kalai-tw changed the title FM2-636: Enhancements in Existing FHIR Task Resource (#5) FM2-636: Enhancements in Existing FHIR Task Resource Apr 10, 2024
Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This mostly LGTM. It would be good to add at least one integration test that verifies some of the changes here.

Also is there no need to be able to search for tasks by these attributes? I would imagine, for example, that being able to search by code would be very useful.

@kalai-tw kalai-tw requested a review from ibacher April 10, 2024 16:08
@kalai-tw
Copy link
Contributor Author

Hello @ibacher ! Thanksa for the feedbacks !

Yeap ! We would need Search By Code & Search By For Reference . Have added them in this new commit !

Also, Have Added the Integrations Tests now :)

@dkayiwa
Copy link
Member

dkayiwa commented Apr 23, 2024

@kalai-tw do you mind looking into the above failing build?

@ibacher
Copy link
Member

ibacher commented May 16, 2024

@kalai-tw Could you rebase this branch on master, since we've committed the fix for the test?

@kalai-tw
Copy link
Contributor Author

thanq @ibacher rebased & now the PR pipeline looks green ! can u help on squash & merging the same ?

@ibacher ibacher merged commit 5c02764 into openmrs:master May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants