-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FM2-636: Enhancements in Existing FHIR Task Resource #539
Conversation
FM2-636: Enhancements in Existing FHIR Task Resource (#5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This mostly LGTM. It would be good to add at least one integration test that verifies some of the changes here.
Also is there no need to be able to search for tasks by these attributes? I would imagine, for example, that being able to search by code would be very useful.
api/src/test/java/org/openmrs/module/fhir2/api/translators/impl/TaskTranslatorImplTest.java
Outdated
Show resolved
Hide resolved
api/src/test/java/org/openmrs/module/fhir2/api/translators/impl/TaskTranslatorImplTest.java
Outdated
Show resolved
Hide resolved
api/src/test/java/org/openmrs/module/fhir2/api/translators/impl/TaskTranslatorImplTest.java
Outdated
Show resolved
Hide resolved
Hello @ibacher ! Thanksa for the feedbacks ! Yeap ! We would need Search By Code & Search By For Reference . Have added them in this new commit ! Also, Have Added the Integrations Tests now :) |
@kalai-tw do you mind looking into the above failing build? |
@kalai-tw Could you rebase this branch on master, since we've committed the fix for the test? |
thanq @ibacher rebased & now the PR pipeline looks green ! can u help on squash & merging the same ? |
Description of what I changed
Made below Changes to FHIR Task Entity Model:
Added new columns to
fhir_task
:task_code
: to determine task typeexecution_start_time
: start time of executionexecution_end_time
: end time of executioncomment
: comment to taskAdded a new table
fhir_part_of_reference
to support subtasks to a parent task.Issue I worked on
see https://issues.openmrs.org/browse/FM2-636
talk thread ref https://talk.openmrs.org/t/contribution-to-fhir-task/42015
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
I have added tests to cover my changes.
I ran
mvn clean package
right before creating this pull requestAll new and existing tests passed.
My pull request is based on the latest changes of the master branch.