-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FHIR Create R4 Questionnaire API #541
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
============================================
+ Coverage 77.84% 77.93% +0.08%
- Complexity 2683 2741 +58
============================================
Files 239 244 +5
Lines 7452 7593 +141
Branches 901 918 +17
============================================
+ Hits 5801 5917 +116
- Misses 1115 1129 +14
- Partials 536 547 +11 ☔ View full report in Codecov by Sentry. |
For right now, this isn't going to be accepted in to the FHIR2 module. However, FHIR resources can be defined in custom modules that rely on the FHIR2 module. Here's an example. The rationale for relegating this is that forms are always specific to a form engine implementation, but OpenMRS Core (and hence the FHIR2 module) are agnostic about the form engine implementation. |
Description of what I changed
Create R4 Questionnaire API
The Questionnaire will be converted from an
org.openmrs.Form
, for that, the form must have aorg.openmrs.FormResource
with aname
equal toFHIR Questionnaire
where the value is a JSON that represents the Questionnaire.If a specific Questionnaire is request by
id
,uuid
, orname
and doesn't have aFormResource
with aname
equal toFHIR Questionnaire
the following error message is shown:If a request for all Questionnaires is made, only
Forms
with aFormResource
with aname
equal toFHIR Questionnaire
are returned.Issue I worked on
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amend
I ran
mvn clean package
right before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master