TRUNK-6203: Global properties access should be privileged #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@dkayiwa I updated this PR. We also need this to run the reference application. |
Yes we need to. |
Strangely, it sometimes works without these changes 😅 |
Not a good sign. 😊 |
That happened only once, it was probably an issue on my side. |
dkayiwa
reviewed
May 30, 2024
| @@ -81,8 +82,16 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response) | |||
| // look up the allowed # of attempts per IP | |||
| Integer allowedLockoutAttempts = 100; | |||
|
|
|||
| String allowedLockoutAttemptsGP = Context.getAdministrationService().getGlobalProperty( | |||
| GP_ALLOWED_LOGIN_ATTEMPTS_PER_IP, "100"); | |||
| String allowedLockoutAttemptsGP = ""; | |||
There was a problem hiding this comment.
Why not initialise this with the default value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After TRUNK-6203, users must possess the 'Get Global Properties' privilege to access global properties. This addition and removal of the global property are necessary for accessing global properties before a user logs in.
Ticket: https://openmrs.atlassian.net/browse/TRUNK-6203