Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct issue of 3.3.1 #204

Merged
merged 2 commits into from
Oct 9, 2024
Merged

correct issue of 3.3.1 #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a02e9a
correct issue of 3.3.1
slubwama Oct 9, 2024
91110e1
resolve 3.3.1 in mergePatientsForm.jsp
slubwama Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion omod/src/main/webapp/admin/patients/mergePatientsForm.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ function toggleUnvoidedOrderErrorMessage(){
<input type="hidden" id="pref" name="preferred" value=""/>
<input type="hidden" id="nonPref" name="nonPreferred" value=""/>
<input type="hidden" name="modalMode" value='${modalMode}' />
<input type="hidden" name="redirectURL" value='<request:header name="referer" />' />
<input type="hidden" name="redirectURL" value='<c:out value="${pageContext.request.getHeader('referer')}"/>' />
</c:if>
</form>

Expand Down
3 changes: 1 addition & 2 deletions omod/src/main/webapp/portlets/login.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@
<input type="hidden" name="redirect" value="" />
</c:otherwise>
</c:choose>

<input type="hidden" name="refererURL" value='<request:header name="referer" />' />
<input type="hidden" name="refererURL" value='<c:out value="${pageContext.request.getHeader('referer')}"/>' />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the XSS attack came via the referer param?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

</c:if>

</form>
Expand Down
Loading