Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCLOMRS-1050-fixes-to-failing-precision-import #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

moshonk
Copy link
Contributor

@moshonk moshonk commented Oct 17, 2021

Fixed a JSON deserialization issue on Boolean fields defined as String. The issue was mostly affecting the concepts' precision property. Tested against this subscription https://api.openconceptlab.org/orgs/MSFOCP/collections/OCL-Subscription-Module-Test/1

@moshonk moshonk requested a review from ibacher October 17, 2021 00:37
@ibacher
Copy link
Member

ibacher commented Oct 18, 2021

@moshonk Thanks for this. I think, though, that this isn't an issue we should try to fix. I.e., it's expected that precise will be a boolean and we are properly rejecting it when it's a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants