O3-2862 - Queue Module - validate that queue entry falls within visit… #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when saving visit
… when saving visit
ibacher
previously approved these changes
Feb 14, 2024
ibacher
approved these changes
Feb 14, 2024
… when saving visit or when saving queue entry
mogoodrich
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
LGTM, thanks @mseaton ... nice that you can add in validators for existing objects this way.
| Date stopDateTime = visit.getStopDatetime(); | ||
|
|
||
| QueueEntrySearchCriteria criteria = new QueueEntrySearchCriteria(); | ||
| criteria.setIsEnded(null); |
There was a problem hiding this comment.
I assume setting this to null means returns all queues, both those that are ended and those that aren't ended.
There was a problem hiding this comment.
Correct, the default (which I don't love, but the way it is implemented) is to only return active entries by default. So to get all entries, you need to explicitly null out this property :/
…n a visit is stopped, any associated queue entries are ended on the visit stop datetime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when saving visit