(breaking) O3-2899 - queue service should not limit to only active qu… #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eue entries by default
|
@mseaton , we should also remove this line from the unit tests: |
ojwanganto
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eue entries by default
This is a breaking change, as existing queries to the service, including usage by the REST endpoint, will not include both active and ended queue entries by default, unless the "isActive=true" parameter is passed in. We will need to update the frontend code to ensure this is being passed in, but given this frontend code is a work in progress, and the existing code was causing a lot of confusion and errors, I wanted to get this fixed.