O3-2904 Queue Module - queue should not have Queue Entries as a direc… #59
Conversation
mseaton
requested review from
ojwanganto,
jecihjoy,
donaldkibet,
ibacher and
dkayiwa
… auto close visit queue entry task runs
| @@ -62,30 +63,9 @@ public class Queue extends BaseChangeableOpenmrsMetadata { | |||
| @JoinColumn(name = "status_concept_set", referencedColumnName = "concept_id") | |||
| private Concept statusConceptSet; | |||
|
|
|||
| @OneToMany(mappedBy = "queue", cascade = CascadeType.ALL, fetch = FetchType.LAZY) | |||
| private List<QueueEntry> queueEntries; | |||
There was a problem hiding this comment.
I'm a little confused by this part of the change. Does this mean that queues no longer have queue entries?
There was a problem hiding this comment.
@ibacher yes, basically. It says that "Queue Entries" are associated with a Queue via a 1-many relationship, but a Queue does not directly have access to the entries that are associated with it. Can you find another example of where it's been our practice to have data belong to metadata directly? You can't get a List<PatientProgram> from a Program for example, even if one might think they want to do something like program.getEnrollments()
There was a problem hiding this comment.
Nope. It always bothered me that we had this direct linkage! In retrospect, I should've just read the ticket.
There was a problem hiding this comment.
The refactoring makes sense. Thanks @mseaton
…t property