(fix) O3-3066 update queue entries accordingly after merging patients #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseaton
reviewed
Apr 11, 2024
There was a problem hiding this comment.
One comment but generally looks good to me, assuming this works. Do the save handlers operate in the same transaction? Hard to test with our junit tests which work within a single transaction that gets rolled back, but I would think you could / should test what happens if there is an exception thrown by the SaveHandler - do things end up in an invalid state?
| Person winner = mergeLog.getWinner(); | ||
| Person loser = mergeLog.getLoser(); | ||
| Patient winnerPatient = Context.getPatientService().getPatient(winner.getPersonId()); | ||
| Patient loserPatient = Context.getPatientService().getPatient(loser.getPersonId()); |
There was a problem hiding this comment.
You should Autowire the patient service in through the constructor as you are doing with the QueueEntryService
|
Closing this as this approach does not work, unfortunately. The SaveHandler does not seem to be called within the same transaction that initiates the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging 2 patients, all queue entries from the loser (voided) patient should be set to associate with the winner patient.
This PR does it by adding a SaveHandler on PersonMergeLog. Not sure if this is the right approach, since we have the same issue of needing to update queue entries when merging visits, we can't do something similar since there is no VisitMergeLog.