PLAT-82: Add PostgreSQL support #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Oct 2, 2024
| ('Auto close queue entries Task', 'Auto close queue entries Task', 'org.openmrs.module.queue.tasks.AutoCloseQueueEntryTask', | ||
| TIMESTAMP(CURDATE()), 'MM/dd/yyyy HH:mm:ss', 86400, TRUE, 1, NOW(), UUID()); | ||
| </sql> | ||
| <insert tableName="scheduler_task_config"> |
There was a problem hiding this comment.
Did you confirm that that modifying this changeset will not lead to validation checksum errors?
There was a problem hiding this comment.
should I create a separate changeset for Postgresql?
There was a problem hiding this comment.
@dkayiwa updated this by adding a validCheckSum tag.
ibacher
reviewed
Oct 2, 2024
api/src/main/resources/liquibase.xml
Outdated
| @@ -400,7 +405,7 @@ | |||
| <addForeignKeyConstraint baseColumnNames="visit_id" baseTableName="queue_entry" constraintName="queue_entry_visit_id_fk" onDelete="NO ACTION" onUpdate="NO ACTION" referencedColumnNames="visit_id" referencedTableName="visit"/> | |||
| </changeSet> | |||
|
|
|||
| <changeSet id="migrate_visit_id_to_queue_entry_20231025" author="mseaton"> | |||
| <changeSet id="migrate_visit_id_to_queue_entry_20231025" author="mseaton" dbms="mysql"> | |||
There was a problem hiding this comment.
Suggested change
| <changeSet id="migrate_visit_id_to_queue_entry_20231025" author="mseaton" dbms="mysql"> | |
| <changeSet id="migrate_visit_id_to_queue_entry_20231025" author="mseaton" dbms="mysql,mariadb"> |
There was a problem hiding this comment.
@ibacher I updated the PR.
ibacher
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PostgreSQL compatibility issues in the liquibase.xml