Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify GitHub Action with matrix strategy #82

Closed

Conversation

kavindu-udara
Copy link

Simplified the GitHub Action workflow by implementing a matrix strategy to build the project with multiple Java versions (8, 11, 17).

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Kavindu,

Thanks a lot for the PR! You perfectly nailed the solution. We merged #81 as it was submitted earlier, so I'm going to close this PR. Just one small comment: we usually add a newline at the end of the file as a best practice. you can google "EOF" to find out why :)

Appreciate your efforts and hope to see more contributions from you!

Much love from the OpenMRS team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants