Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing DrugResource1_12 for RESTWS-760 #626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snowvirus
Copy link

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@snowvirus
Copy link
Author

@dkayiwa @RandilaP @zabil @ibacher @suubi-joshua please help me and review my work
i beg you please

@ibacher
Copy link
Member

ibacher commented Oct 7, 2024

First, please look at existing PRs for this repo to get a sense of what we expect in PRs. In particular, PRs should have a Jira issue (included in the title), a clear description of what they do. Also, please review the checklist in the PR. It is there to help us help you.

I don't really understand what this PR is trying to do; it seems to be just reformatting things and it seems to do this inappropriately. Please review our Java conventions.

@dkayiwa
Copy link
Member

dkayiwa commented Oct 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants