Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEUI 311 #273

Merged
merged 7 commits into from
Dec 12, 2024
Merged

OEUI 311 #273

merged 7 commits into from
Dec 12, 2024

Conversation

mogoodrich
Copy link
Member

@mogoodrich mogoodrich commented Dec 9, 2024

JIRA TICKET NAME

Support Order Reason for Lab Orders

https://openmrs.atlassian.net/browse/OEUI-311

Summary

  • sample summary

I have checked that on this Pull request

  • I can sucessfully create Drug orders
  • I can sucessfully create Lab orders
  • I can sucessfully search for drug orders

@mogoodrich mogoodrich marked this pull request as draft December 9, 2024 18:37
@coveralls
Copy link

coveralls commented Dec 12, 2024

Pull Request Test Coverage Report for Build 12302685183

Details

  • 18 of 55 (32.73%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.5%) to 81.799%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/js/components/Draft.jsx 4 7 57.14%
app/js/reducers/draftReducer/draftLabOrderReducer.js 0 5 0.0%
app/js/reducers/orderReasonsReducer.js 2 12 16.67%
app/js/actions/fetchOrderReasonsGlobalProperty.js 3 22 13.64%
Totals Coverage Status
Change from base Build 4641162487: -2.5%
Covered Lines: 959
Relevant Lines: 1109

💛 - Coveralls

(fix tests and linting, add docs)
@@ -196,6 +196,15 @@ Then administrator should make the following one time configurations using the a
6. Add global property `orderentryowa.labOrderAutoExpireTimeInDays` with a value of `30` days or any other number
7. Add global propery Lab Orderables Concept Set `orderentryowa.labOrderablesConceptSet`, whose value is the UUID of a concept set of Class LabSet and whose Set Members are other LabSet concept sets or concept of Class Test.

### Additional features

As of version 1.3.0, the module supports a collecting an "order reason" for Lab Orders. Order reasons are specified at
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning on doing release before merging this in, and this is my target next version, will update if that changes

@mogoodrich mogoodrich marked this pull request as ready for review December 12, 2024 17:59
@mogoodrich
Copy link
Member Author

@mseaton @chibongho @cioan flagging you all for review, though I know none of us have looked at this code in years. I suspect we will just go with a cursory review + testing.

@mogoodrich mogoodrich merged commit 7fbadc2 into master Dec 12, 2024
1 check passed
@mogoodrich mogoodrich deleted the OEUI-311 branch December 12, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants