Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copying excess files to output directory #101

Closed
wants to merge 1 commit into from

Conversation

james-elicx
Copy link
Collaborator

Context
We currently copy everything in .next to the output directory when we only utilise .next/standalone.

Changes

  • Copies the standalone directory instead of the .next directory.

Copy link

changeset-bot bot commented Oct 13, 2024

🦋 Changeset detected

Latest commit: 63daa64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 13, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@101

commit: 63daa64

@james-elicx james-elicx force-pushed the james/refactor-config-slightly branch 2 times, most recently from 7b0d08d to 8076b05 Compare October 14, 2024 06:32
Base automatically changed from james/refactor-config-slightly to main October 23, 2024 19:28
@james-elicx james-elicx force-pushed the james/copying-excess-files branch 2 times, most recently from 35209d0 to 4d1da8e Compare October 23, 2024 19:36
@james-elicx james-elicx force-pushed the james/copying-excess-files branch from 4d1da8e to 63daa64 Compare October 23, 2024 19:37
@james-elicx james-elicx marked this pull request as ready for review October 23, 2024 19:42

fix: copying excess files to output directory

In previous versions, we copied the entire `.next` directory to the `.worker-next` output directory. Going forward, it will only copy the `.next/standalone` directory to this location.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In previous versions, we copied the entire `.next` directory to the `.worker-next` output directory. Going forward, it will only copy the `.next/standalone` directory to this location.
In previous versions, we copied the entire `.next` directory to the `.worker-next` output directory. Since this is not necessary, going forward, we will only copy the `.next/standalone` directory to this location.

@dario-piotrowicz dario-piotrowicz requested a review from vicb October 29, 2024 11:39
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move away from this copy when we integrate with open next.
Then I don't think there is a need to change that now.

@james-elicx james-elicx deleted the james/copying-excess-files branch October 31, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants