feat: cli arg to disable minification #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2f5cb03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
james-elicx
changed the title
commit: |
james-elicx
force-pushed
the
james/minification-option
branch
from
bb5fd4a to
0f67650
Compare
james-elicx
force-pushed
the
james/minification-option
branch
from
0f67650 to
0ad33df
Compare
vicb
reviewed
Oct 11, 2024
vicb
requested changes
Oct 11, 2024
vicb
reviewed
Oct 11, 2024
vicb
reviewed
Oct 11, 2024
vicb
reviewed
Oct 11, 2024
vicb
reviewed
Oct 11, 2024
vicb
approved these changes
Oct 11, 2024
|
Thanks a lot for updating the code @james-elicx. Sorry to bother you with nit-picks but I think it's goos to start to improve things little by little. |
It's no worries at all, I don't mind it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a CLI arg to let people choose to disable minification (e.g. for debugging purposes).
Only applies to the cache handler at the moment as that's the only part being minified currently.