Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use ALS for process.env object #98

Closed
wants to merge 8 commits into from
+62 −38
Closed

refactor: use ALS for process.env object #98

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
335fac5
refactor: extract proxy creation into utility
james-elicx Oct 12, 2024
627d10b
refactor: move process.env to ALS proxy
james-elicx Oct 12, 2024
e7f9206
Apply suggestions from code review
james-elicx Oct 18, 2024
4be38fa
use ALS for entire process object
james-elicx Oct 23, 2024
4628b62
changeset
james-elicx Oct 23, 2024
9ecefdf
Revert "use ALS for entire process object"
james-elicx Oct 23, 2024
d3a2bde
change overriding to only be the env obj
james-elicx Oct 23, 2024
9f13e52
capture original process.env value
james-elicx Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changeset
@james-elicx
james-elicx committed Oct 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 4628b628669ef000b565bfd77446ced7b24dedcf
7 changes: 7 additions & 0 deletions .changeset/funny-impalas-attend.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@opennextjs/cloudflare": patch
---

refactor: use ALS for `process.env` object.

The adaptor was previously manipulating the global process.env object on every request, without accounting for other requests. ALS has been introduced to change this behavior, so that each process.env object is scoped to the request.