Skip to content

Commit

Permalink
chore(deps): use netlify-cli dev dep where possible
Browse files Browse the repository at this point in the history
Ubuntu 24.04 (now ubuntu-latest) has removed the `netlify` CLI :(

We were installing it manually in some CI workflows, but not the e2e report one, which started
failing.

This fixes that by pulling in the easy parts of #2484.
  • Loading branch information
serhalp committed Oct 16, 2024
1 parent 01651dc commit 9bf4485
Show file tree
Hide file tree
Showing 7 changed files with 39,781 additions and 12,459 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ jobs:
- name: Deploy e2e page
if: success()
run: |
ntl deploy --build --cwd e2e-report
npx netlify deploy --build --cwd e2e-report
10 changes: 2 additions & 8 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,7 @@ jobs:
env:
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
run: |
# TODO(serhalp) Unpin version once
# https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
npm i -g [email protected]
netlify login
npx netlify login
- name: Get installed Playwright version
id: playwright-version
run: echo "version=$(npm view @playwright/test version)" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -208,10 +205,7 @@ jobs:
env:
NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
run: |
# TODO(serhalp) Unpin version once
# https://netlify.slack.com/archives/C07686YAY13/p1718139257978049 is resolved.
npm i -g [email protected]
netlify login
npx netlify login
- name: Resolve Next.js version
id: resolve-next-version
shell: bash
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,8 @@ jobs:
run: npm run build
working-directory: ${{ env.runtime-path }}

# TODO(serhalp) Use the netlify-cli dev dep? It's a bit trickier here because we're running in
# the next.js directory, not the next-runtime directory. See https://github.com/netlify/next-runtime/pull/2484.
- name: add netlify cli
run: npm install -g netlify-cli

Expand Down
Loading

0 comments on commit 9bf4485

Please sign in to comment.