fix: use version of htmlrewriter which does not make use of asyncify, which looks to have a potential memory leak under high load #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which looks to have a potential memory leak under high load we noticed the memory issue with Netlify's CSP plugin which used the same htmlrewriter library. We've built a new htmlrewriter library which uses the latest version of lol-html and removes the ability to use async-handlers, which is what required asyncify to be included.
serhalp
reviewed
Dec 9, 2024
edge-runtime/lib/response.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import type { Context } from '@netlify/edge-functions' | |||
| import { HTMLRewriter } from '../vendor/deno.land/x/[email protected]/index.ts' | |||
| import { HTMLRewriter, init, type TextChunk } from 'https://deno.land/x/[email protected]/src/index.ts' | |||
There was a problem hiding this comment.
@JakeChampion I'm not super familiar with this setup, but it looks like all our deno imports use a relative path and should be included in this file 🤔
pieh
force-pushed
the
jake/htmlrewriter
branch
from
4a359c6 to
b76dfb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We noticed the memory issue with Netlify's CSP plugin which used the same htmlrewriter library. We've built a new htmlrewriter library which uses the latest version of lol-html and removes the ability to use async-handlers, which is what required asyncify to be included.
Documentation
This is intended to be a pure refactor and have no user visible changes, as such no documentation updates should be required
Tests
You can test this change yourself like so:
deno test -A edge-runtime/Relevant links (GitHub issues, etc.) or a picture of cute animal
https://deno.land/x/[email protected]