rtos: mqx: replace malloc+strcpy with strdup

Using strcpy is potentially dangerous so just use a safer and easier way to do the same. Signed-off-by: Paul Fertser <[email protected]> Change-Id: Id85f3b7f8af1eaf14c9951ae710546d2437c70b5 Reviewed-on: https://review.openocd.org/c/openocd/+/8597 Reviewed-by: Antonio Borneo <[email protected]> Tested-by: jenkins
openocd-org · Dec 22, 2024 · dca76cd · dca76cd
1 parent 42f70a3
commit dca76cd
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/rtos/mqx.c b/src/rtos/mqx.c
@@ -380,10 +380,9 @@ static int mqx_update_threads(
 		rtos->thread_details[i].threadid = task_id;
 		rtos->thread_details[i].exists = true;
 		/* set thread name */
-		rtos->thread_details[i].thread_name_str = malloc(strlen((void *)task_name) + 1);
+		rtos->thread_details[i].thread_name_str = strdup((char *)task_name);
 		if (!rtos->thread_details[i].thread_name_str)
 			return ERROR_FAIL;
-		strcpy(rtos->thread_details[i].thread_name_str, (void *)task_name);
 		/* set thread extra info
 		 * - task state
 		 * - task address