Update links in footer to point to cove-bods repo #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once OpenDataServices/lib-cove-web#18 is in a release, this PR should just need the requirements updating. |
Bjwebb
changed the title
This means the about section of the footer is now correctly replaced.
odscjames
approved these changes
Apr 4, 2019
odscjames
reviewed
Apr 4, 2019
| @@ -118,6 +118,12 @@ <h1 class="heading-in-panel"> <small> {% blocktrans %}Using the data review tool | |||
| {% block bottomcontent3 %} | |||
| {% endblock %} | |||
|
|
|||
| {% block about %} | |||
| <li>{% trans "Built by" %} <a href="http://opendataservices.coop/">{% trans "Open Data Services" %}</a></li> | |||
| <li>{% trans "The code for this site is available on" %}<br>{% trans "GitHub" %}: <a href="https://github.com/openownership/cove-bods/">cove-bods</a><br>{% trans "Licence" %}: <a href="https://www.gnu.org/licenses/agpl-3.0.html">{% trans "AGPLv3" %}</a><br>{% trans "Report/View issues" %}: <a href="https://github.com/openownership/cove-bods/issues">{% trans "cove-bods issues" %}</a> | |||
There was a problem hiding this comment.
I would have put this on multiple lines for readability tho :-)
|
Whoops. Just realised this P.R. added new trans phrases but did NOT include updating the message strings as set out in the readme. Oh well, that will happen as part of #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25
This is waiting for this lib-cove-web PR OpenDataServices/lib-cove-web#18