Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kathryn ods patch 1 #723

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Kathryn ods patch 1 #723

wants to merge 12 commits into from

Conversation

kathryn-ods
Copy link
Contributor

Overview

What does this pull request do?
updates example data - componentRecords fields were listing statementIds, now they list recordIds

How can a reviewer test or examine your changes?

Who is best placed to review it?

Closes #

Translations

  • New or edited strings appearing as a result of this PR will be picked up for translation
  • I've notified the translation coordinator of any new strings that will need
    translating. See the Handbook

Documentation & Release

componentRecords in this example were statementIds but should be recordIds
componentStatements was statementIds but should be recordIds
componentRecords was statementIds but should be recordIds
fixing a typo
changing statementIds to recordIds in componentRecords
@kd-ods
Copy link
Collaborator

kd-ods commented Aug 23, 2024

@kathryn-ods - you can remove your changes to examples/bods-package-fi-soe.json from this PR, since I fixed the component recordId in PR #727

@kathryn-ods
Copy link
Contributor Author

@kathryn-ods - you can remove your changes to examples/bods-package-fi-soe.json from this PR, since I fixed the component recordId in PR #727

Have done this now and re-requested a review

@kathryn-ods
Copy link
Contributor Author

having an issue with the link check tests - https://www.iso20022.org/market-identifier-codes showing as broken

@kathryn-ods
Copy link
Contributor Author

ok I removed and readded the link and that seems to have worked

@kd-ods
Copy link
Collaborator

kd-ods commented Sep 3, 2024

@kathryn-ods - I'll take a look at this Wed.

Copy link
Collaborator

@kd-ods kd-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of the example files could do with checking again.

It's a headache getting these componentRecords lists right.

examples/multiple-indirect-ownership.json Outdated Show resolved Hide resolved
examples/mutilple-indirect-ownership-2.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants