Fixing Build error with ICU 4.6 and Fixing compile time type errors #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake/FindICU.cmake with one from facebook/hiphop-php repo.
Summary: last_used_con was used for replication within libmysqlclient but this was never enabled or used. MySQL developers killed it all in 5.5.0. Use an #ifdef for now in case we're using some experimental stuff somewhere. Test Plan: Built against MySQL 5.5 and our external version DiffCamp Revision: 177173 Reviewed By: hzhao CC: hzhao, hphp-diffs@lists Revert Plan: Ok
Explanation: Const pointer had to name the class for the type, rather than the constructor. The error in both files was: error: "‘HPHP::ClassInfo::ClassInfo’ names the constructor, not the type".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with ICU version 4.6 there is an error involving the ICU version check. Requirements are for 4.2+. With 4.6 it failed and instead of the current version number being output, source code was spammed to the screen. This uses the current FindICU.cmake file from the facebook/hiphop-php repo and fixes the bug.
I included a bug fix from the facebook/hiphop-php repo for MySQL 5.5 support. Reference for what these changes in MySQL were see this revision: http://bazaar.launchpad.net/~mysql/mysql-server/mysql-5.5/revision/[email protected]
There was a bug (2334676 - Fix const pointer type error.) where is would not accept const ClassInfo::ClassInfo *info syntax and complained that it was a constructor and not the name of the type. Changing it to const ClassInfo *info fixed this. This is on x86_64 architecture, Linux (Archlinux) and GCC 4.5.2.