-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend create_table()
#118
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6461997
Add `form_type` class to app data
jthompson-arcus 05b869c
Minimal solution
jthompson-arcus 655662b
Merge branch 'dev' into jt-107-extend_create_table
jthompson-arcus 6a06ffc
Merge branch 'dev' into jt-107-extend_create_table
jthompson-arcus 3f38993
Simplify `form_types` creation
jthompson-arcus 802bc29
Update version and NEWS
jthompson-arcus d220c70
Resolve merge conflicts with `dev`
jthompson-arcus 4f9ba5e
Merge branch 'dev' into jt-107-extend_create_table
jthompson-arcus f884d68
Update version number
jthompson-arcus 056b99e
Add S3 generic to `_pkgdown.yml`
jthompson-arcus 746033a
Change `create_table.common_events` to `create_table.common_forms`
jthompson-arcus 5121075
Add `form_type` to `metadata$item_expanded`
jthompson-arcus cf53ca7
Repair `fct_appdata.R` tests
jthompson-arcus f159dd3
Add `create_table.common_forms()` tests
jthompson-arcus 147c521
Simplify form string
jthompson-arcus d3cf1b0
Update version
jthompson-arcus 3315a24
Resolve merge conflicts with `dev`
jthompson-arcus 4b73522
Resolve merge conflicts with `dev`
jthompson-arcus ce8bb74
Update version number
jthompson-arcus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Package: clinsight | ||
Title: ClinSight | ||
Version: 0.1.0.9007 | ||
Version: 0.1.0.9008 | ||
Authors@R: c( | ||
person("Leonard Daniël", "Samson", , "[email protected]", role = c("cre", "aut"), | ||
comment = c(ORCID = "0000-0002-6252-7639")), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is good to wrap form_type_x also in
simplify_string
. That way the user is protected against some hard to detect changes in the names (for example, accidentally adding a leading or trailing white space in the table's name in the Excel file)