Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve merge conflicts main #142

Merged
merged 20 commits into from
Nov 20, 2024
Merged

Resolve merge conflicts main #142

merged 20 commits into from
Nov 20, 2024

Conversation

jthompson-arcus
Copy link
Collaborator

No description provided.

LDSamson and others added 19 commits November 15, 2024 12:10
…g if the result is not UTF8 (i.e. if the string was initially not encoded)

(cherry picked from commit a22a5b5)
(cherry picked from commit 1e72f44)
(cherry picked from commit d62de80)
(cherry picked from commit 3381f26)
(cherry picked from commit 279bc5c)
Merge branch 'main' into jt-resolve_merge_conflicts_main

# Conflicts:
#	DESCRIPTION
#	NEWS.md
#	R/fct_utils.R
#	inst/golem-config.yml
#	tests/testthat/_snaps/mod_review_forms.md
#	tests/testthat/fixtures/review_testdb.sqlite
#	tests/testthat/test-mod_review_forms.R
@jthompson-arcus jthompson-arcus marked this pull request as ready for review November 19, 2024 20:34
Copy link
Collaborator

@LDSamson LDSamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only made a tiny change in alignment

@LDSamson LDSamson merged commit 906daf8 into dev Nov 20, 2024
3 checks passed
@LDSamson LDSamson deleted the jt-resolve_merge_conflicts_main branch November 20, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants