Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pageLength bug #150

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Fix pageLength bug #150

merged 3 commits into from
Dec 17, 2024

Conversation

jthompson-arcus
Copy link
Collaborator

The DataTable extension Scroller is disabled on a couple query tables, but the pageLength is still set at 10. This PR changes the pageLength to all rows. Typically there is not a lot of data in these tables, so enabling all rows shouldn't be a problem.

@jthompson-arcus jthompson-arcus marked this pull request as ready for review December 13, 2024 19:40
Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Jeff. Thank you!

Copy link
Collaborator

@LDSamson LDSamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, I did not yet notice this issue!

@LDSamson LDSamson merged commit d5b80d2 into dev Dec 17, 2024
5 checks passed
@LDSamson LDSamson deleted the jt-fix_pageLength_bug branch December 17, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants