-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
061 part 1 - make applicable user roles available in the app #63
Conversation
…tion. For shiinymanager, use only one initial role (data frame restriction).
… ones are available
…eview_config, update tests
(cherry picked from commit a57d0e4)
fe85d15
to
5edc33c
Compare
@jthompson-arcus and @aclark02-arcus this PR is ready. Would one of you be able to review this somehwere this week? This is the 'base' PR for some (soon available) follow-up PRs that ultimately will make the user role visible in multiple places in the application, and will document the role together with the user name when needed. |
@jthompson-arcus I noticed that the input of the HTTP header that contains the role information in ShinyProxy needs sanitizing; it gives the roles in all capital letters, and returns a single string, with all roles separated with commas. Therefore, the changes in my latest PR do not yet work properly in the production environment. I am working on a change to fix this. In general, I will do something like this for both the posit_connect group variable and the shinyproxy one:
I think if the string is already sanitized, this will not change the outcome. However, please let me know if this is not the case or if this is not desirable for deployment using posit connect |
…void confusion), add some unit tests. (cherry picked from commit 4406c755b79148c5ec4f5825d16ad84227ec7b53)
… function authenticate_server.
Connect will already parse the object with that deployment. Shiny will see the object as a list. |
Okay I will fix it so that it also works with posit connect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few discussion points below.
Sorry if any comments are addressed in the follow up PRs. I tried to cross reference a little.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is step 1 to resolve #61 .
After this PR is implemented, the application will:
golem-config.yml
)In the rare case that multiple roles are available, it will select the first role available (in the order as defined in the
config
file.If no roles are available, an empty character will be provided as user role.