Improve UI #87
Merged
Improve UI #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st header UI, and gives undesireable result in some resolutions)
LDSamson
force-pushed
the
ls-improve-UI
branch
from
1356d5b to
1d43648
Compare
LDSamson
commented
Sep 18, 2024
Comment on lines
22
to
24
| title = tags$a( | ||
| href = "/", | ||
| tags$img(src='www/gcp_logo.png', height = '40', width ='180') |
There was a problem hiding this comment.
For us, this small change is quite useful since it gives us a possibility to navigate back to the home page within ShinyProxy. In later updates, we can make this more flexible so that the user can set the link and/or the logo.
|
@jthompson-arcus and @aclark02-arcus I will merge this PR due to time restrictions and since it is just a UI update (although I personally quite like these changes!). If you encounter any problems with it, please let me know in a follow-up issue report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements:
Better use of space, grouping of buttons, slightly tweak facet height:
Furthermore, a bit better text sizing of value box texts by setting a minimum text size:
And the figure legend is now bigger but hidden in a popover so that it does not distract from the main content:
