-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify coordinates and visits_zero_index #366
Conversation
Code Coverage Summary
Diff against main
Results for commit: 6d0c939 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Thanks @clarkliming , does this then also close #270 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice simplification, thanks @clarkliming !
Co-authored-by: Daniel Sabanes Bove <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, thanks!!
maybe we can wait for CRAN 0.3.5 release accepted and then merge |
I would merge now. this will not affect the release, it will be part of next version |
close #110
current implementation unifies coordinates and visits.
There is an extra data conversion so it is expected there is a small cost.
Average computation time for
FEV1 ~ ARMCD + us(AVISIT|USUBJID)
onfev_data
decrease from 37.53347 ms to 37.89274 ms (but still very small and neglectable I think)In addition, the select matrix is removed but instead use "subset_matrix" functionality