Enable translation of the export's filename

This way users will have a named in Catalan which will be more user friendly for them.
openpoke · Oct 8, 2020 · c621ad2 · c621ad2
1 parent 9142118
commit c621ad2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/app/jobs/decidim/action_delegator/export_consultation_results_job.rb b/app/jobs/decidim/action_delegator/export_consultation_results_job.rb
@@ -3,15 +3,13 @@
 module Decidim
   module ActionDelegator
     class ExportConsultationResultsJob < ApplicationJob
-      EXPORT_NAME = "consultation_results"
-
       queue_as :default
 
       def perform(user, consultation)
         @consultation = consultation
 
         export_data = Decidim::Exporters.find_exporter("CSV").new(collection, serializer).export
-        ExportMailer.export(user, EXPORT_NAME, export_data).deliver_now
+        ExportMailer.export(user, I18n.t("decidim.admin.consultations.results.export_name"), export_data).deliver_now
       end
 
       private

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -67,6 +67,7 @@ en:
       consultations:
         results:
           export: Export
+          export_name: "consultation_results"
           membership_type: Membership type
           membership_weight: Weight
     authorization_handlers:

diff --git a/spec/jobs/decidim/action_delegator/export_consultation_results_job_spec.rb b/spec/jobs/decidim/action_delegator/export_consultation_results_job_spec.rb
@@ -57,7 +57,7 @@ module Decidim::ActionDelegator
       it "sends an export mail" do
         expect(Decidim::ExportMailer)
           .to receive(:export)
-          .with(user, "consultation_results", kind_of(Decidim::Exporters::ExportData))
+          .with(user, I18n.t("decidim.admin.consultations.results.export_name"), kind_of(Decidim::Exporters::ExportData))
           .and_return(mailer)
 
         subject.perform_now(user, consultation)