fix some tests, fix hide button

app/views/decidim/reporting_proposals/admin/proposals/_proposal_td_hide.html.erb

@@ -5,7 +5,7 @@
   <% else %>
     <%= cell("decidim/flag_modal", proposal, modal_id: "flagModal#{proposal.id}") %>
     <button type="button" class="action-icon icon--small action-icon--show-proposal"
-            data-open="<%= current_user.present? ? "flagModal#{proposal.id}" : "loginModal" %>"
+            data-dialog-open="<%= current_user.present? ? "flagModal#{proposal.id}" : "loginModal" %>"
             title="<%= t("report", scope: "decidim.proposals.admin.proposals.show") %>"
             aria-controls="<%= current_user.present? ? "flagModal#{proposal.id}" : "loginModal" %>"
             aria-haspopup="true"

spec/controllers/admin/proposals_controller_spec.rb

@@ -119,14 +119,14 @@ module Admin
         context "when the user is not in the organization" do
           let(:user) { create(:user, :confirmed, :admin) }
 
-          it_behaves_like "hide failure", "You are not authorized to perform this action"
+          it_behaves_like "hide failure", "You are not authorized to perform this action."
         end
 
         context "when the proposal is not in the organization" do
           let(:user) { create(:user, :confirmed, :admin) }
           let(:organization) { user.organization }
 
-          it_behaves_like "hide failure", "You are not authorized to perform this action"
+          it_behaves_like "hide failure", "You are not authorized to perform this action."
         end
       end
 

spec/controllers/decidim/proposals/proposals_controller_spec.rb

@@ -312,7 +312,7 @@ def proposal_path(_options)
 
               put :withdraw, params: params.merge(id: proposal.id)
 
-              expect(flash[:alert]).to eq("You are not authorized to perform this action")
+              expect(flash[:alert]).to eq("You are not authorized to perform this action.")
               expect(response).to have_http_status(:found)
               proposal.reload
               expect(proposal.withdrawn?).to be false

spec/events/decidim/proposals/publish_proposal_event_spec.rb

@@ -115,7 +115,7 @@ module Proposals
         describe "notification_title" do
           it "is generated correctly" do
             expect(subject.notification_title)
-              .to eq("The proposal <a href=\"#{resource_path}\">A nice proposal</a> has been added to #{participatory_space_title} by #{author.name} <a href=\"/profiles/#{author.nickname}\">@#{author.nickname}</a>")
+              .to eq("The proposal <a href=\"#{resource_path}\">A nice proposal</a> has been added to#{participatory_space_title} by #{author.name} <a href=\"/profiles/#{author.nickname}\">@#{author.nickname}</a>.")
           end
         end
       end

spec/system/admin/assign_valuators_spec.rb

@@ -103,13 +103,13 @@
       it "has permission to access assigned" do
         visit Decidim::EngineRouter.admin_proxy(component).proposal_path(proposal)
         expect(page).to have_content(proposal.title["en"])
-        expect(page).to have_no_content("You are not authorized to perform this action")
+        expect(page).to have_no_content("You are not authorized to perform this action.")
       end
 
       it "has no permission to access" do
         visit Decidim::EngineRouter.admin_proxy(component).proposal_path(another_proposal)
         expect(page).to have_no_content(another_proposal.title["en"])
-        expect(page).to have_content("You are not authorized to perform this action")
+        expect(page).to have_content("You are not authorized to perform this action.")
       end
     end
   end

spec/system/decidim/proposals/admin/valuator_manages_proposals_spec.rb

@@ -60,7 +60,7 @@
         click_link_or_button("button#js-submit-unassign-proposals-from-valuator")
       end
 
-      expect(page).to have_content("You are not authorized to perform this action")
+      expect(page).to have_content("You are not authorized to perform this action.")
     end
   end