Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to viash 0.9 #911

Merged
merged 10 commits into from
Oct 31, 2024
Merged

update to viash 0.9 #911

merged 10 commits into from
Oct 31, 2024

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Oct 11, 2024

Describe your changes

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
    • Documentation
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

rcannood and others added 8 commits October 11, 2024 15:32
* update to viash 0.9 and categorise datasets

* group workflows

* add api for spatial datasets

* add more metadata

* update publish dir path

* update project config

* update namespace

* fix id

* update example

* fix example

* update test resources

* update helper resources

* fix multiple separator

---------

Co-authored-by: Robrecht Cannoodt <[email protected]>
* migrate components

* remove resources which were moved to common_resources

* remove more resources which were moved to common resources

* update components

* update scripts

* wip migrate reporting components

* rename components

* update scripts

* update components

* more fixes

* update

* remove setup logging helper

* fix components
@rcannood
Copy link
Member Author

rcannood commented Oct 19, 2024

Status:

  • Need to decide on a new format for the results
  • Need to create a schema for the v1 result format and the new (v3) format
  • Resources are missing from results.json (info in the trace.txt is not being linked properly)

@rcannood rcannood requested a review from sainirmayi October 22, 2024 14:19
- name: datasets/processors/pca
- name: datasets/processors/hvg
- name: datasets/processors/knn
- name: common/extract_metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: common/extract_metadata
- name: utils/extract_uns_metadata

- name: datasets/normalization/sqrt_cp
- name: datasets/normalization/l1_sqrt
- name: datasets/processors/subsample
- name: common/extract_metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: common/extract_metadata
- name: utils/extract_uns_metadata

- name: datasets/processors/pca
- name: datasets/processors/hvg
- name: datasets/processors/knn
- name: common/extract_metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: common/extract_metadata
- name: utils/extract_uns_metadata

- name: datasets/normalization/sqrt_cp
- name: datasets/normalization/l1_sqrt
- name: datasets/processors/subsample
- name: common/extract_metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: common/extract_metadata
- name: utils/extract_uns_metadata

- name: datasets/normalization/sqrt_cp
- name: datasets/normalization/l1_sqrt
- name: datasets/processors/subsample
- name: common/extract_metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: common/extract_metadata
- name: utils/extract_uns_metadata

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nextflow run command needs to be updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tower launch command needs to be updated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nextflow run command needs to be updated.

@rcannood rcannood merged commit 56e4278 into main Oct 31, 2024
37 checks passed
@rcannood rcannood deleted the update-viash-0.9 branch October 31, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants