Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve co-ranking metrics #4

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Oct 9, 2024

Also bump memory requirement

Describe your changes

Use the {Rfast} package to calculate distance matrices in the co-ranking metrics. Should be significantly faster.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@lazappi lazappi requested a review from rcannood October 9, 2024 06:59
src/metrics/coranking/script.R Outdated Show resolved Hide resolved
src/metrics/coranking/script.R Outdated Show resolved Hide resolved
@rcannood rcannood merged commit b845d57 into main Oct 22, 2024
2 checks passed
@rcannood rcannood deleted the feature/no-ref/improve-coranking branch October 22, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants