Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update task result rendering #296

Merged
merged 31 commits into from
Dec 20, 2023
Merged

Update task result rendering #296

merged 31 commits into from
Dec 20, 2023

Conversation

KaiWaldrant
Copy link
Contributor

@KaiWaldrant KaiWaldrant commented Nov 22, 2023 •
edited by rcannood
Loading

Describe your changes

  • Show task motivation, if present.
  • Allow multiple citations for datasets, methods, and metrics.
  • Render dataset name instead of dataset id in figures and tables.
  • Change the way bibliographic references are rendered.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Preview succeeds and looks good!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited
Loading

Deploy: success

@KaiWaldrant
Copy link
Contributor Author

The v2 results are being rendered in the batch Integration feature benchmark.

@KaiWaldrant
Copy link
Contributor Author

KaiWaldrant commented Nov 22, 2023 •
edited by rcannood
Loading

Looks like the metrics section doesn't like the long summaries.

It does work for the short summaries:

image

KaiWaldrant and others added 17 commits November 29, 2023 14:26
@rcannood rcannood changed the title add v2 results Update task result rendering Dec 20, 2023
@rcannood rcannood merged commit b7301b1 into main Dec 20, 2023
1 check passed
@rcannood rcannood deleted the update/add_v2_results branch December 20, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaiWaldrant @rcannood