-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more information to benchmarks (method, metric and general info) #365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Some minor comments:
missing data shows up as character(0)
If certain data is missing it shows up as character(0)
. I agree that the some data should always be available, but just on the off-chance that it isn't, it wouldn't be bad to add a check.
Use nicer labels
Use capitalisation and fewer abbreviations. It'd be better to write Repository
and Issues
instead of repo
and issues
. The same applies for dataset, method and metric info: docs
→ Documentation
, source
→ Repository
, implementation
→ Source code
, container
→ Container
.
Dataset tags
I like the tags for methods and metrics. Can we do something similar for datasets as well?
Certain references show up as [@]
This might be related to the reference being a bibtex entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd write the library.bib
file only once, at the end of the qmd.
However, looks good to me as is.
Describe your changes
perturbation_prediction
results with info added from Update reporting components to include all links openproblems#915preview
Related issues
Closes openproblems-bio/task_perturbation_prediction#83
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Preview succeeds and looks good!