Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information to benchmarks (method, metric and general info) #365

Merged
merged 110 commits into from
Nov 26, 2024

Conversation

KaiWaldrant
Copy link
Member

@KaiWaldrant KaiWaldrant commented Nov 13, 2024

Describe your changes

preview

Related issues

Closes openproblems-bio/task_perturbation_prediction#83

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Preview succeeds and looks good!

@KaiWaldrant KaiWaldrant requested a review from rcannood November 13, 2024 10:37
Copy link

github-actions bot commented Nov 13, 2024

Deploy: success

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Some minor comments:

missing data shows up as character(0)

If certain data is missing it shows up as character(0). I agree that the some data should always be available, but just on the off-chance that it isn't, it wouldn't be bad to add a check.

Screenshot from 2024-11-21 14-58-02

Use nicer labels

Use capitalisation and fewer abbreviations. It'd be better to write Repository and Issues instead of repo and issues. The same applies for dataset, method and metric info: docsDocumentation, sourceRepository, implementationSource code, containerContainer.

Dataset tags

I like the tags for methods and metrics. Can we do something similar for datasets as well?

Certain references show up as [@]

This might be related to the reference being a bibtex entry?

Screenshot from 2024-11-21 15-03-18

@KaiWaldrant KaiWaldrant requested a review from rcannood November 26, 2024 06:41
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd write the library.bib file only once, at the end of the qmd.

However, looks good to me as is.

@rcannood rcannood merged commit d3b719d into main Nov 26, 2024
1 check passed
@rcannood rcannood deleted the feature/no-ref/add-info-to-method branch November 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric info is rendered incorrectly on the website
2 participants