Assignment preprocesses: Fix domain content keys #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melisabok
reviewed
Aug 19, 2024
| const quota = domain.content?.['submission_assignment_max_' + reviewersName.toLowerCase()]?.value | ||
| const inviteAssignmentId = domain.content?.[reviewersName.toLowerCase() + '_invite_assignment_id']?.value | ||
| const quota = domain.content?.['submission_assignment_max_reviewers']?.value | ||
| const inviteAssignmentId = domain.content?.['reviewers_invite_assignment_id']?.value |
There was a problem hiding this comment.
I think this won't work for area chairs assignment. May be the invitation should have another variable here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some preprocess functions we retrieve fields from the domain using the committee name in the key. The problem is that these fields are hardcoded and don't use the committee name. It's an issue for venues that use custom role names.