Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matching.py #2496

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Update matching.py #2496

merged 4 commits into from
Feb 10, 2025

Conversation

emily-grabowski
Copy link
Contributor

update to check for a matching assignment title instead of 'Deployed' state.

fixes #2472

update to check for a matching assignment title instead of 'Deployed' state.
@celestemartinez celestemartinez self-requested a review February 3, 2025 18:49
@melisabok
Copy link
Member

is there a test to verify this?

I see the previous fix was being tested but why we didn't catch this error?

@celestemartinez
Copy link
Member

is there a test to verify this?

I see the previous fix was being tested but why we didn't catch this error?

Not sure how to test this, since the matcher is the one that calls venue.set_assignments(). This was working in the test because it looks like the ARR v2 test was setting the status of the config as 'Deployed'. However, this is done by the matcher after set_assignments() is called.

# impersonate user to get all the permissions to deploy the groups
venue.client.impersonate(self.config_note_interface.venue_id)
venue.set_assignments(
    assignment_title=self.config_note_interface.label,
    committee_id=self.config_note_interface.match_group,
    overwrite=True,
    enable_reviewer_reassignment=True,
)

self.config_note_interface.set_status(MatcherStatus.DEPLOYED)```

@melisabok melisabok merged commit f0c78cf into master Feb 10, 2025
6 checks passed
@melisabok melisabok deleted the fix/default-max-papers-matching-name branch February 10, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting default Custom Max Papers weight
3 participants